Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ISR issue with index.ts #1563

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

J3tto
Copy link
Contributor

@J3tto J3tto commented Aug 19, 2021

For the root path / the s3StorePage was not correctly storing to the index.html file and instead was storing as .html

Added an extra regex replace() to deal with the root path.

#1098

@J3tto J3tto changed the title Fix ISR issue with index.ts Fix ISR issue with index.ts Aug 19, 2021
@dphang
Copy link
Collaborator

dphang commented Aug 20, 2021

Thanks! I'll add a test for this as well so it doesn't break in the future.

@dphang
Copy link
Collaborator

dphang commented Aug 20, 2021

Hm, for some reason CI is failing on ENOENT: no such file or directory, lstat '/home/runner/.cache/yarn/v6/npm-@aws-sdk-client-sqs-3.27.0-a1d982019362cdd1c39901092c7a944278966627-integrity/node_modules/@aws-sdk/client-sqs/CHANGELOG.md'. Seems like a spurious error as it is working locally. Maybe try to rebase to the latest master (I don't have permissions to do that for you) so I can rerun the CI?

For the root path `/` the `s3StorePage` was not correctly storing to the index.html file and instead was storing as `.html`

Added an extra regex replace() to deal with the root path.
@J3tto
Copy link
Contributor Author

J3tto commented Aug 24, 2021

Updated, Hopefully that works

@slsnextbot
Copy link
Collaborator

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit e63f99c)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1247,
            "Minified": 441
        },
        "API Lambda": {
            "Standard": 86,
            "Minified": 34
        },
        "Image Lambda": {
            "Standard": 911,
            "Minified": 360
        },
        "Regeneration Lambda": {
            "Standard": 637,
            "Minified": 227
        }
    }
}

New Handler Sizes (kB) (commit 5911d8f)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1247,
            "Minified": 441
        },
        "API Lambda": {
            "Standard": 86,
            "Minified": 34
        },
        "Image Lambda": {
            "Standard": 911,
            "Minified": 360
        },
        "Regeneration Lambda": {
            "Standard": 637,
            "Minified": 227
        }
    }
}

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #1563 (5911d8f) into master (e63f99c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1563   +/-   ##
=======================================
  Coverage   84.32%   84.32%           
=======================================
  Files          97       97           
  Lines        3425     3425           
  Branches     1016     1016           
=======================================
  Hits         2888     2888           
  Misses        477      477           
  Partials       60       60           
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/s3/s3StorePage.ts 90.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63f99c...5911d8f. Read the comment docs.

@dphang
Copy link
Collaborator

dphang commented Aug 25, 2021

Thanks!

@dphang dphang merged commit d327ddf into serverless-nextjs:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants