-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ISR issue with index.ts
#1563
Fix ISR issue with index.ts
#1563
Conversation
Thanks! I'll add a test for this as well so it doesn't break in the future. |
Hm, for some reason CI is failing on |
For the root path `/` the `s3StorePage` was not correctly storing to the index.html file and instead was storing as `.html` Added an extra regex replace() to deal with the root path.
04381d9
to
5911d8f
Compare
Updated, Hopefully that works |
Handler Size Report
Base Handler Sizes (kB) (commit e63f99c){
"Lambda@Edge": {
"Default Lambda": {
"Standard": 1247,
"Minified": 441
},
"API Lambda": {
"Standard": 86,
"Minified": 34
},
"Image Lambda": {
"Standard": 911,
"Minified": 360
},
"Regeneration Lambda": {
"Standard": 637,
"Minified": 227
}
}
} New Handler Sizes (kB) (commit 5911d8f){
"Lambda@Edge": {
"Default Lambda": {
"Standard": 1247,
"Minified": 441
},
"API Lambda": {
"Standard": 86,
"Minified": 34
},
"Image Lambda": {
"Standard": 911,
"Minified": 360
},
"Regeneration Lambda": {
"Standard": 637,
"Minified": 227
}
}
} |
Codecov Report
@@ Coverage Diff @@
## master #1563 +/- ##
=======================================
Coverage 84.32% 84.32%
=======================================
Files 97 97
Lines 3425 3425
Branches 1016 1016
=======================================
Hits 2888 2888
Misses 477 477
Partials 60 60
Continue to review full report at Codecov.
|
Thanks! |
For the root path
/
thes3StorePage
was not correctly storing to theindex.html
file and instead was storing as.html
Added an extra regex
replace()
to deal with the root path.#1098