fix(lambda-at-edge): static regeneration while running in ISR mode #1729

[cmaerz]

No description provided.

[dphang]

Looks like some unit tests failed

[cmaerz]

@dphang Yeah.. I can‘t get the build running currently. See: #1729
Maybe you can help me there, than I can fix the tests :D

[dphang]

Hm, are archiver types added properly? You can also try to delete the yarn lock file temporarily and regenerate it, sometimes it helped me when dependencies are having issues

[cmaerz]

Hm.. deleting yarn.lock didn't help. Tbh I don't even know what archiver is, I didn't add that package :D

[slsnextbot]

Handler Size Report

There are changes to handler sizes. Please review.

Base Handler Sizes (kB) (commit 2612f08)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1560,
            "Minified": 550
        },
        "API Lambda": {
            "Standard": 101,
            "Minified": 44
        },
        "Image Lambda": {
            "Standard": 933,
            "Minified": 371
        },
        "Regeneration Lambda": {
            "Standard": 655,
            "Minified": 237
        }
    }
}

New Handler Sizes (kB) (commit 0f5cc5d)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1290,
            "Minified": 461
        },
        "API Lambda": {
            "Standard": 101,
            "Minified": 44
        },
        "Image Lambda": {
            "Standard": 943,
            "Minified": 375
        },
        "Regeneration Lambda": {
            "Standard": 665,
            "Minified": 242
        }
    }
}

[codecov]

Codecov Report

Merging #1731 (b25e18c) into master (2612f08) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head b25e18c differs from pull request most recent head 0f5cc5d. Consider uploading reports for the commit 0f5cc5d to get more accurate results

@@           Coverage Diff           @@
##           master    #1731   +/-   ##
=======================================
  Coverage   83.85%   83.86%           
=======================================
  Files          98       98           
  Lines        3494     3496    +2     
  Branches     1048     1048           
=======================================
+ Hits         2930     2932    +2     
  Misses        500      500           
  Partials       64       64           

Impacted Files	Coverage Δ
...ackages/libs/lambda-at-edge/src/default-handler.ts	87.00% <ø> (ø)
...ambda-at-edge/src/lib/triggerStaticRegeneration.ts	95.65% <ø> (ø)
...es/libs/lambda-at-edge/src/regeneration-handler.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2612f08...0f5cc5d. Read the comment docs.

[dphang]

ran e2e tests: https://github.com/serverless-nextjs/serverless-next.js/actions/runs/1268687056