Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs-component, core, lambda-at-edge): experimental - add buil… #1747

Merged
merged 12 commits into from
Sep 27, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Sep 26, 2021

…d.useV2Handler option to enable using genericized default/regeneration handlers

@slsnextbot
Copy link
Collaborator

slsnextbot commented Sep 26, 2021

Handler Size Report

There are changes to handler sizes. Please review.

Base Handler Sizes (kB) (commit 4b39103)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1290,
            "Minified": 461
        },
        "Default Lambda V2": {
            "Standard": 1489,
            "Minified": 642
        },
        "API Lambda": {
            "Standard": 101,
            "Minified": 44
        },
        "Image Lambda": {
            "Standard": 943,
            "Minified": 375
        },
        "Regeneration Lambda": {
            "Standard": 665,
            "Minified": 242
        },
        "Regeneration Lambda V2": {
            "Standard": 648,
            "Minified": 250
        }
    }
}

New Handler Sizes (kB) (commit 10bbc56)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1061,
            "Minified": 382
        },
        "Default Lambda V2": {
            "Standard": 1536,
            "Minified": 660
        },
        "API Lambda": {
            "Standard": 101,
            "Minified": 44
        },
        "Image Lambda": {
            "Standard": 943,
            "Minified": 375
        },
        "Regeneration Lambda": {
            "Standard": 665,
            "Minified": 242
        },
        "Regeneration Lambda V2": {
            "Standard": 695,
            "Minified": 267
        }
    }
}

@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #1747 (10bbc56) into master (419663a) will increase coverage by 0.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1747      +/-   ##
==========================================
+ Coverage   83.86%   83.88%   +0.01%     
==========================================
  Files          98       98              
  Lines        3496     3499       +3     
  Branches     1048     1051       +3     
==========================================
+ Hits         2932     2935       +3     
  Misses        500      500              
  Partials       64       64              
Impacted Files Coverage Δ
packages/libs/core/src/handle/default.ts 85.71% <ø> (ø)
...es/libs/lambda-at-edge/src/regeneration-handler.ts 100.00% <ø> (ø)
packages/libs/lambda-at-edge/src/build.ts 96.31% <85.71%> (+0.03%) ⬆️
packages/libs/core/src/build/index.ts 95.45% <100.00%> (ø)
...ackages/libs/lambda-at-edge/src/default-handler.ts 87.00% <100.00%> (ø)
...ambda-at-edge/src/lib/triggerStaticRegeneration.ts 95.83% <100.00%> (+0.18%) ⬆️
...rless-components/nextjs-component/src/component.ts 85.26% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419663a...10bbc56. Read the comment docs.

@dphang dphang mentioned this pull request Sep 27, 2021
7 tasks
@dphang dphang merged commit afd8a79 into master Sep 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/v2-handlers-component branch September 27, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants