Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cloudfront): handle bucket names with dots correctly #1844

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Oct 15, 2021

As per AWS documentation, bucket names can contain dots. This was addressed in this PR, but it was never merged. Hopefully this can be merged.

@slsnextbot
Copy link
Collaborator

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit d47e537)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1540,
            "Minified": 668
        },
        "Default Lambda V2": {
            "Standard": 1496,
            "Minified": 660
        },
        "API Lambda": {
            "Standard": 631,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1471,
            "Minified": 797
        },
        "Regeneration Lambda": {
            "Standard": 606,
            "Minified": 244
        },
        "Regeneration Lambda V2": {
            "Standard": 655,
            "Minified": 267
        }
    }
}

New Handler Sizes (kB) (commit 1e06862)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1540,
            "Minified": 668
        },
        "Default Lambda V2": {
            "Standard": 1496,
            "Minified": 660
        },
        "API Lambda": {
            "Standard": 631,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1471,
            "Minified": 797
        },
        "Regeneration Lambda": {
            "Standard": 606,
            "Minified": 244
        },
        "Regeneration Lambda V2": {
            "Standard": 655,
            "Minified": 267
        }
    }
}

@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #1844 (1e06862) into master (d47e537) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1844   +/-   ##
=======================================
  Coverage   83.55%   83.56%           
=======================================
  Files          98       99    +1     
  Lines        3502     3504    +2     
  Branches     1061     1061           
=======================================
+ Hits         2926     2928    +2     
  Misses        512      512           
  Partials       64       64           
Impacted Files Coverage Δ
...ponents/aws-cloudfront/src/getBucketNameFromUrl.ts 100.00% <100.00%> (ø)
...s-components/aws-cloudfront/src/getOriginConfig.ts 95.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47e537...1e06862. Read the comment docs.

@dphang
Copy link
Collaborator

dphang commented Oct 16, 2021

Thanks!

@dphang dphang merged commit 918a19e into serverless-nextjs:master Oct 16, 2021
@tomi tomi deleted the fix-extraction-of-s3-bucket-name-when-it-contains-dots branch October 18, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants