Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(domain): add domain input minimumProtocolVersion #1916

Merged
merged 1 commit into from
Oct 24, 2021

Conversation

ari-luokkala
Copy link
Contributor

Fix for #1878

@slsnextbot
Copy link
Collaborator

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit a3b435b)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1494,
            "Minified": 658
        },
        "Image Lambda": {
            "Standard": 1460,
            "Minified": 791
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 2078,
            "Minified": 959
        },
        "Default Lambda V2": {
            "Standard": 1497,
            "Minified": 660
        },
        "API Lambda": {
            "Standard": 632,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1468,
            "Minified": 796
        },
        "Regeneration Lambda": {
            "Standard": 1162,
            "Minified": 537
        },
        "Regeneration Lambda V2": {
            "Standard": 1227,
            "Minified": 563
        }
    }
}

New Handler Sizes (kB) (commit 7f42e6e)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1494,
            "Minified": 658
        },
        "Image Lambda": {
            "Standard": 1460,
            "Minified": 791
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 2078,
            "Minified": 959
        },
        "Default Lambda V2": {
            "Standard": 1497,
            "Minified": 660
        },
        "API Lambda": {
            "Standard": 632,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1468,
            "Minified": 796
        },
        "Regeneration Lambda": {
            "Standard": 1162,
            "Minified": 537
        },
        "Regeneration Lambda V2": {
            "Standard": 1227,
            "Minified": 563
        }
    }
}

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #1916 (7f42e6e) into master (a3b435b) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1916      +/-   ##
==========================================
- Coverage   83.92%   83.76%   -0.17%     
==========================================
  Files         100      100              
  Lines        3534     3541       +7     
  Branches     1072     1074       +2     
==========================================
  Hits         2966     2966              
- Misses        510      515       +5     
- Partials       58       60       +2     
Impacted Files Coverage Δ
...ackages/serverless-components/domain/serverless.js 0.00% <0.00%> (ø)
packages/serverless-components/domain/utils.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b435b...7f42e6e. Read the comment docs.

@@ -498,6 +499,13 @@ const removeDomainFromCloudFrontDistribution = async (
};
};

const isMinimumProtocolVersionValid = (minimumProtocolVersion) => {
// https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-viewercertificate.html
const validMinimumProtocolVersions = /(^SSLv3$|^TLSv1$|^TLSv1.1_2016$|^TLSv1.2_2018$|^TLSv1.2_2019$|^TLSv1.2_2021$|^TLSv1_2016$)/g;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to check this though in the future I think the AWS SDK also throws a 400 status, so you could remove this later too

@dphang dphang merged commit b49d2fe into serverless-nextjs:master Oct 24, 2021
@dphang
Copy link
Collaborator

dphang commented Oct 24, 2021

Thanks, will publish it soon (sorting out some upgrades with renovate/yarn first)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants