Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-lambda): wait for lambda to be ready right after creation/upd… #1985

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Oct 29, 2021

…ating of code

  • When Lambda code is created or updated, it needs to be ready before doing anything else (even updating lambda config)

@slsnextbot
Copy link
Collaborator

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit 7682e13)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1497,
            "Minified": 659
        },
        "Image Lambda": {
            "Standard": 1463,
            "Minified": 793
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1508,
            "Minified": 665
        },
        "Default Lambda V2": {
            "Standard": 1500,
            "Minified": 662
        },
        "API Lambda": {
            "Standard": 632,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1472,
            "Minified": 798
        },
        "Regeneration Lambda": {
            "Standard": 1164,
            "Minified": 538
        },
        "Regeneration Lambda V2": {
            "Standard": 1230,
            "Minified": 565
        }
    }
}

New Handler Sizes (kB) (commit 0072347)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1497,
            "Minified": 659
        },
        "Image Lambda": {
            "Standard": 1463,
            "Minified": 793
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1508,
            "Minified": 665
        },
        "Default Lambda V2": {
            "Standard": 1500,
            "Minified": 662
        },
        "API Lambda": {
            "Standard": 632,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1472,
            "Minified": 798
        },
        "Regeneration Lambda": {
            "Standard": 1164,
            "Minified": 538
        },
        "Regeneration Lambda V2": {
            "Standard": 1230,
            "Minified": 565
        }
    }
}

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #1985 (c51bd02) into master (7682e13) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c51bd02 differs from pull request most recent head 0072347. Consider uploading reports for the commit 0072347 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1985   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files         102      102           
  Lines        3623     3624    +1     
  Branches     1142     1142           
=======================================
+ Hits         3038     3039    +1     
  Misses        573      573           
  Partials       12       12           
Impacted Files Coverage Δ
.../serverless-components/aws-lambda/src/component.ts 71.42% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7682e13...0072347. Read the comment docs.

@dphang dphang merged commit 016fee0 into master Oct 29, 2021
@dphang dphang deleted the dphang/wait-lambda-fix branch October 29, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants