Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cloudfront, nextjs-component): specify s3 client's region in … #2042

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Nov 15, 2021

…aws-cloudfront the same as the bucket region

Should fix: #2041

…aws-cloudfront the same as the bucket region
@slsnextbot
Copy link
Collaborator

slsnextbot commented Nov 15, 2021

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit b9b5cfd)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1523,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1487,
            "Minified": 801
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1533,
            "Minified": 673
        },
        "Default Lambda V2": {
            "Standard": 1525,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1495,
            "Minified": 806
        },
        "Regeneration Lambda": {
            "Standard": 1183,
            "Minified": 544
        },
        "Regeneration Lambda V2": {
            "Standard": 1253,
            "Minified": 572
        }
    }
}

New Handler Sizes (kB) (commit adafb0e)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1523,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1487,
            "Minified": 801
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1533,
            "Minified": 673
        },
        "Default Lambda V2": {
            "Standard": 1525,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1495,
            "Minified": 806
        },
        "Regeneration Lambda": {
            "Standard": 1183,
            "Minified": 544
        },
        "Regeneration Lambda V2": {
            "Standard": 1253,
            "Minified": 572
        }
    }
}

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #2042 (8688ac4) into master (a7041af) will decrease coverage by 0.07%.
The diff coverage is 50.00%.

❗ Current head 8688ac4 differs from pull request most recent head adafb0e. Consider uploading reports for the commit adafb0e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2042      +/-   ##
==========================================
- Coverage   83.59%   83.51%   -0.08%     
==========================================
  Files         102      102              
  Lines        3651     3658       +7     
  Branches     1150     1154       +4     
==========================================
+ Hits         3052     3055       +3     
- Misses        588      592       +4     
  Partials       11       11              
Impacted Files Coverage Δ
...rless-components/nextjs-component/src/component.ts 86.36% <ø> (ø)
packages/libs/core/src/route/data.ts 89.18% <33.33%> (-10.82%) ⬇️
...verless-components/aws-cloudfront/src/component.ts 81.53% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9b5cfd...adafb0e. Read the comment docs.

@dphang
Copy link
Collaborator Author

dphang commented Nov 15, 2021

Failure due to accidental concurrent run of same e2e tests, but considering some passed and this is a deployment logic change, it should be fine.

@dphang dphang merged commit a676d03 into master Nov 15, 2021
@dphang dphang deleted the dphang--fix-bucket-region branch November 15, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ap-east-1 location constraint is incompatible for the region specific endpoint this request was sent to.
2 participants