Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudfront): add ability to set ResponseHeadersPolicyId #2285

Conversation

chrisneal
Copy link
Contributor

I have added the ability to set the ResponseHeadersPolicyId on the Cloudfront behaviours.

I had to update some snapshots to get the tests to pass, though I get failures when Jest gets to the Running coverage on untested files... section.

I haven't had a chance to run an end-to-end test with it yet though.

@slsnextbot
Copy link
Collaborator

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit 6363903)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1524,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1488,
            "Minified": 800
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1533,
            "Minified": 673
        },
        "Default Lambda V2": {
            "Standard": 1526,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1496,
            "Minified": 805
        },
        "Regeneration Lambda": {
            "Standard": 1187,
            "Minified": 546
        },
        "Regeneration Lambda V2": {
            "Standard": 1253,
            "Minified": 573
        }
    }
}

New Handler Sizes (kB) (commit 9b0fe5e)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1524,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1488,
            "Minified": 800
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1533,
            "Minified": 673
        },
        "Default Lambda V2": {
            "Standard": 1526,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1496,
            "Minified": 805
        },
        "Regeneration Lambda": {
            "Standard": 1187,
            "Minified": 546
        },
        "Regeneration Lambda V2": {
            "Standard": 1253,
            "Minified": 573
        }
    }
}

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #2285 (9b0fe5e) into master (6363903) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2285   +/-   ##
=======================================
  Coverage   83.54%   83.55%           
=======================================
  Files         102      102           
  Lines        3671     3673    +2     
  Branches     1169     1171    +2     
=======================================
+ Hits         3067     3069    +2     
  Misses        592      592           
  Partials       12       12           
Impacted Files Coverage Δ
...-components/aws-cloudfront/src/getCacheBehavior.ts 100.00% <100.00%> (ø)
...ents/aws-cloudfront/src/getDefaultCacheBehavior.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6363903...9b0fe5e. Read the comment docs.

@dphang
Copy link
Collaborator

dphang commented Jan 24, 2022

Thx! Let me run E2E tests but I think it should be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants