New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudfront): add ability to set RealtimeLogConfigARN #2301
Conversation
Handler Size Report
Base Handler Sizes (kB) (commit 36a1751){
"Lambda": {
"Default Lambda": {
"Standard": 1524,
"Minified": 668
},
"Image Lambda": {
"Standard": 1488,
"Minified": 800
}
},
"Lambda@Edge": {
"Default Lambda": {
"Standard": 1534,
"Minified": 673
},
"Default Lambda V2": {
"Standard": 1526,
"Minified": 670
},
"API Lambda": {
"Standard": 634,
"Minified": 318
},
"Image Lambda": {
"Standard": 1496,
"Minified": 805
},
"Regeneration Lambda": {
"Standard": 1187,
"Minified": 546
},
"Regeneration Lambda V2": {
"Standard": 1253,
"Minified": 573
}
}
} New Handler Sizes (kB) (commit 456125b){
"Lambda": {
"Default Lambda": {
"Standard": 1524,
"Minified": 668
},
"Image Lambda": {
"Standard": 1488,
"Minified": 800
}
},
"Lambda@Edge": {
"Default Lambda": {
"Standard": 1534,
"Minified": 673
},
"Default Lambda V2": {
"Standard": 1526,
"Minified": 670
},
"API Lambda": {
"Standard": 634,
"Minified": 318
},
"Image Lambda": {
"Standard": 1496,
"Minified": 805
},
"Regeneration Lambda": {
"Standard": 1187,
"Minified": 546
},
"Regeneration Lambda V2": {
"Standard": 1253,
"Minified": 573
}
}
} |
Codecov Report
@@ Coverage Diff @@
## master #2301 +/- ##
=======================================
Coverage 83.55% 83.55%
=======================================
Files 102 102
Lines 3673 3673
Branches 1171 1171
=======================================
Hits 3069 3069
Misses 592 592
Partials 12 12 Continue to review full report at Codecov.
|
hi @dphang 👋 |
Sure I think it looks fine, though not sure why the CI tests aren't running? |
@dphang anyone that can look into that or merging the PR? |
maybe just try to re trigger those 2 circle ci jobs. |
No worries! I think we can merge and let master CI work |
this fixes #2284
this works adding in the configuration yaml: