Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudfront): add ability to set RealtimeLogConfigARN #2301

Merged
merged 3 commits into from Jan 27, 2022

Conversation

Raffaello
Copy link
Contributor

@Raffaello Raffaello commented Jan 24, 2022

this fixes #2284

this works adding in the configuration yaml:

defaults: # optional
        realtimeLogConfigArn: 'the realtime log config ARN'

@Raffaello Raffaello mentioned this pull request Jan 24, 2022
@slsnextbot
Copy link
Collaborator

slsnextbot commented Jan 24, 2022

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit 36a1751)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1524,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1488,
            "Minified": 800
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1534,
            "Minified": 673
        },
        "Default Lambda V2": {
            "Standard": 1526,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1496,
            "Minified": 805
        },
        "Regeneration Lambda": {
            "Standard": 1187,
            "Minified": 546
        },
        "Regeneration Lambda V2": {
            "Standard": 1253,
            "Minified": 573
        }
    }
}

New Handler Sizes (kB) (commit 456125b)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1524,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1488,
            "Minified": 800
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1534,
            "Minified": 673
        },
        "Default Lambda V2": {
            "Standard": 1526,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1496,
            "Minified": 805
        },
        "Regeneration Lambda": {
            "Standard": 1187,
            "Minified": 546
        },
        "Regeneration Lambda V2": {
            "Standard": 1253,
            "Minified": 573
        }
    }
}

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #2301 (36a1751) into master (36a1751) will not change coverage.
The diff coverage is n/a.

❗ Current head 36a1751 differs from pull request most recent head b052f4a. Consider uploading reports for the commit b052f4a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2301   +/-   ##
=======================================
  Coverage   83.55%   83.55%           
=======================================
  Files         102      102           
  Lines        3673     3673           
  Branches     1171     1171           
=======================================
  Hits         3069     3069           
  Misses        592      592           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a1751...b052f4a. Read the comment docs.

@Raffaello Raffaello changed the title add RealtimeLogConfigARN to cloudfront distribution defaults feat(cloudfront): add ability to set RealtimeLogConfigARN Jan 25, 2022
@Raffaello
Copy link
Contributor Author

hi @dphang 👋
when you have some time, could you please look into this one?
thanks.

@dphang
Copy link
Collaborator

dphang commented Jan 26, 2022

Sure I think it looks fine, though not sure why the CI tests aren't running?

@Raffaello
Copy link
Contributor Author

Sure I think it looks fine, though not sure why the CI tests aren't running?

@dphang
I don't know, I can't see details.
besides i am not authorized to merge the PR.

anyone that can look into that or merging the PR?

@Raffaello
Copy link
Contributor Author

maybe just try to re trigger those 2 circle ci jobs.

@dphang
Copy link
Collaborator

dphang commented Jan 27, 2022

No worries! I think we can merge and let master CI work

@dphang dphang merged commit 04fec27 into serverless-nextjs:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs
3 participants