Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrong replace causing "on" files on S3 #2392

Merged
merged 2 commits into from Mar 8, 2022

Conversation

JanStevens
Copy link
Contributor

@JanStevens JanStevens commented Mar 2, 2022

Fix the regex to only replace .js at the end of the string

Fixes #2349

Fix the regex to only replace `.js` at the end of the string
@dphang
Copy link
Collaborator

dphang commented Mar 7, 2022

thanks. @JanStevens can you rebase since the lockfile has been fixed on master

@slsnextbot
Copy link
Collaborator

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit ec98072)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1524,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1488,
            "Minified": 800
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1534,
            "Minified": 674
        },
        "Default Lambda V2": {
            "Standard": 1526,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1496,
            "Minified": 805
        },
        "Regeneration Lambda": {
            "Standard": 1187,
            "Minified": 546
        },
        "Regeneration Lambda V2": {
            "Standard": 1253,
            "Minified": 573
        }
    }
}

New Handler Sizes (kB) (commit 99094e2)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1524,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1488,
            "Minified": 800
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1534,
            "Minified": 674
        },
        "Default Lambda V2": {
            "Standard": 1526,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1496,
            "Minified": 805
        },
        "Regeneration Lambda": {
            "Standard": 1187,
            "Minified": 546
        },
        "Regeneration Lambda V2": {
            "Standard": 1253,
            "Minified": 573
        }
    }
}

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #2392 (99094e2) into master (ec98072) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2392   +/-   ##
=======================================
  Coverage   83.77%   83.77%           
=======================================
  Files         102      102           
  Lines        3697     3697           
  Branches     1186     1186           
=======================================
  Hits         3097     3097           
  Misses        588      588           
  Partials       12       12           
Impacted Files Coverage Δ
...es/libs/lambda-at-edge/src/regeneration-handler.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec98072...99094e2. Read the comment docs.

@JanStevens
Copy link
Contributor Author

@dphang done 🎉

@dphang dphang merged commit f6b7efb into serverless-nextjs:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISR pages are regenerated with wrong name when prefetching
3 participants