Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs-component): add deploy input which can be set to false to skip deployment #691

Merged
merged 1 commit into from Oct 18, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Oct 18, 2020

Motivation

This adds support for a new input, deploy that allows users to skip the deployment step (creating AWS resources). All build outputs will be stored in .serverless_nextjs folder - default-lambda, api-lambda, and assets (in same structure as accessed by the handler in s3).

This will give more flexibility to users who may wish to deploy using their own scripts, other IaC (e.g Terraform), etc. User is responsible for uploading all files to S3 themselves (with correct headers), setting CF configuration, uploading Lambdas.

This will close: #642 and #419

Tests

Added a unit test.

@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #691 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   80.10%   80.13%   +0.03%     
==========================================
  Files          54       54              
  Lines        1714     1717       +3     
  Branches      357      358       +1     
==========================================
+ Hits         1373     1376       +3     
  Misses        283      283              
  Partials       58       58              
Impacted Files Coverage Δ
...rless-components/nextjs-component/src/component.ts 89.92% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000377d...eea7afa. Read the comment docs.

@dphang dphang merged commit 5adaf2b into master Oct 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/build-only-input branch October 18, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploying to existing infrastructure
2 participants