Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-at-edge): minor fix to optional catch-all base route at ro… #820

Merged
merged 2 commits into from Nov 26, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Nov 26, 2020

…ot level.

  • minor fix to correct nonDynamic key from "" to "/" at root page level. Even without this, the route should still work because it should still match on the dynamic route (which catches all), but this should help with route precedence.

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #820 (779daf5) into master (9a13afe) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
+ Coverage   80.63%   80.64%   +0.01%     
==========================================
  Files          57       57              
  Lines        1931     1932       +1     
  Branches      430      431       +1     
==========================================
+ Hits         1557     1558       +1     
  Misses        314      314              
  Partials       60       60              
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/build.ts 91.60% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a13afe...779daf5. Read the comment docs.

@dphang dphang merged commit 60cee0d into master Nov 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/minor-fix branch November 26, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant