Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-at-edge): remove blacklisted CloudFront headers before ret… #923

Merged
merged 1 commit into from Mar 4, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Mar 4, 2021

…urning api/default/image handler response

Should fix: #898

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #923 (11278dd) into master (7d393ed) will increase coverage by 0.07%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   81.33%   81.41%   +0.07%     
==========================================
  Files          68       69       +1     
  Lines        2502     2518      +16     
  Branches      596      601       +5     
==========================================
+ Hits         2035     2050      +15     
- Misses        400      401       +1     
  Partials       67       67              
Impacted Files Coverage Δ
...da-at-edge/src/headers/removeBlacklistedHeaders.ts 90.00% <90.00%> (ø)
packages/libs/lambda-at-edge/src/api-handler.ts 85.93% <100.00%> (+0.45%) ⬆️
...ackages/libs/lambda-at-edge/src/default-handler.ts 93.42% <100.00%> (+0.04%) ⬆️
packages/libs/lambda-at-edge/src/image-handler.ts 97.22% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d393ed...4d0b903. Read the comment docs.

@dphang dphang merged commit 3fcb59d into master Mar 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/remove-blacklisted-headers branch March 4, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

502 LambdaValidationError when used in conjunction with http-proxy module, only when deployed
1 participant