Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camel case eventgateway #144

Closed
DavidWells opened this issue Apr 11, 2018 · 3 comments
Closed

Camel case eventgateway #144

DavidWells opened this issue Apr 11, 2018 · 3 comments
Labels
kind/refactoring Refactoring of existing code

Comments

@DavidWells
Copy link
Contributor

Shouldn't eventgateway be eventGateway?

https://github.com/serverless/components/blob/master/registry/eventgateway/serverless.yml#L1

If yes, I can update the references
@DavidWells
Copy link
Contributor Author

Same here https://github.com/serverless/components/blob/master/registry/aws-apigateway/serverless.yml#L1

Should be aws-apiGateway or aws-api-gateway

@brianneisler
Copy link
Contributor

@DavidWells good question. So far we've used train case for component types. I think we should continue to stick to this for now. So eventgateway would be event-gateway and aws-apigateway would be aws-api-gateway

@brianneisler brianneisler mentioned this issue Apr 12, 2018
Closed
@DavidWells
Copy link
Contributor Author

train case is cool. We should update this.

eventgateway just blurs into "even tAg teWay" to me ʕ·ᴥ·ʔ

@brianneisler brianneisler added the kind/refactoring Refactoring of existing code label Sep 19, 2018
@pmuens pmuens closed this as completed Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/refactoring Refactoring of existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DavidWells @brianneisler @pmuens