feat: Fetch bindings.json from official Azure Functions repo (#364)

Simple GET request to fetch the JSON object from the master branch of the GitHub repo.
serverless · Oct 25, 2019 · 4e30115 · 4e30115
1 parent a1d45f0
commit 4e30115
Show file tree

Hide file tree

Showing 9 changed files with 1,635 additions and 932 deletions.
diff --git a/src/config.ts b/src/config.ts
@@ -41,6 +41,7 @@ export const configConstants = {
     prefix: "sls",
     localPort: 7071,
   },
+  bindingsJsonUrl: "https://raw.githubusercontent.com/Azure/azure-functions-templates/master/Functions.Templates/Bindings/bindings.json"
 };
 
 export default configConstants;
diff --git a/src/services/offlineService.test.ts b/src/services/offlineService.test.ts
@@ -40,9 +40,11 @@ describe("Offline Service", () => {
     expect(calls).toHaveLength(functionNames.length + 1);
     for (let i = 0; i < functionNames.length; i++) {
       const name = functionNames[i];
-      expect(calls[i][0]).toEqual(`${name}${path.sep}function.json`)
+      const call = calls.find((c) => c[0] === `${name}${path.sep}function.json`);
+      expect(call).toBeTruthy();
+
       expect(
-        JSON.parse(calls[i][1])
+        JSON.parse(call[1])
       ).toEqual(
         MockFactory.createTestBindingsObject(`..${path.sep}${name}.js`)
       );

diff --git a/src/services/packageService.ts b/src/services/packageService.ts
@@ -26,8 +26,8 @@ export class PackageService extends BaseService {
    */
   public async createBindings(): Promise<void> {
     const createEventsPromises = this.serverless.service.getAllFunctions()
-      .map((functionName) => {
-        const metaData = Utils.getFunctionMetaData(functionName, this.serverless);
+      .map(async (functionName) => {
+        const metaData = await Utils.getFunctionMetaData(functionName, this.serverless);
         return this.createBinding(functionName, metaData);
       });