feat: Added feature to specify Azure subcription ID in CLI before deployment #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarlow12
requested changes
Jul 12, 2019
wbreza
previously requested changes
Jul 12, 2019
tbarlow12
approved these changes
Jul 15, 2019
|
looks good - one low hanging question on Nice work on this! 👍 |
pjlittle
approved these changes
Jul 16, 2019
neerajmandal
dismissed
wbreza’s stale review
Test cases added. It is not recognizing the changes made.
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
…loyment (#203) * option to specify subscription id from CLI added * Build issue resolved * azureBasePlugin issue resolved * Two test cases added to test subscription ID feature * Changes made accoridng to feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature to specify subscription ID in the CLI which overrides any existing subscriptions ID and deploys the functions to the subscription specified by the user.
AB#360