feat: Spawn offline process with sls offline command
#214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
approved these changes
Jul 24, 2019
tbarlow12
force-pushed
the
tabarlow/spawn-child
branch
2 times, most recently
from
4e96afd
to
f836b34
Compare
pjlittle
reviewed
Jul 25, 2019
| */ | ||
| private spawn(command: string, args?: string[], env?: any): Promise<void> { | ||
| env = { | ||
| ...this.serverless.service.provider["environment"], |
|
nice work, looks great 👍 |
pjlittle
approved these changes
Jul 25, 2019
Move spawn to offlineService Add styles to logging Fix tests with log statements
wbreza
force-pushed
the
tabarlow/spawn-child
branch
from
bd5ddd8
to
797a444
Compare
Gta-Cool
reviewed
Jul 25, 2019
| } | ||
| this.log(`Spawning process '${command} ${args.join(" ")}'`); | ||
| return new Promise((resolve, reject) => { | ||
| const childProcess = spawn(command, args, {env}); |
There was a problem hiding this comment.
I don't know if it has been made on purpose (if yes, that requires maybe some documentation), but passing the env variable here as an option is causing the default value process.env to not be used (and more particularly the PATH in it). Taking the PATH from process.env if it hasn't been set as an additional environment variable could be a solution.
tbarlow12
added a commit
that referenced
this pull request
Sep 13, 2019
sls offline builds Azure Functions files and spawns func host start in the same shell sls offline start spawns func host start in the same shell BaseService has spawn function that spawns and waits for child process in shell (routes stdout and stderr to internal logger) Using mock-spawn library to mock spawned child processes Add invocation commands to config constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sls offlinebuilds Azure Functions files and spawnsfunc host startin the same shellsls offline startspawnsfunc host startin the same shellBaseServicehasspawnfunction that spawns and waits for child process in shell (routes stdout and stderr to internal logger)mock-spawnlibrary to mock spawned child processesResolves [AB#569]