Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue fixed to generate the correct function.json for event hub and service bus queue and topic triggers #228

Merged
merged 5 commits into from
Aug 7, 2019
Merged

fix: issue fixed to generate the correct function.json for event hub and service bus queue and topic triggers #228

merged 5 commits into from
Aug 7, 2019

Conversation

neerajmandal
Copy link
Collaborator

@neerajmandal neerajmandal commented Aug 6, 2019 •
edited
Loading

No description provided.

@coveralls
Copy link

coveralls commented Aug 6, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 84.297% when pulling a3b634c on nemand/offlineEventHub into b9bac62 on dev.

@tbarlow12 tbarlow12 self-requested a review August 6, 2019 21:35
tbarlow12
tbarlow12 requested changes Aug 6, 2019
View reviewed changes
Copy link
Collaborator

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change fixed: to fix: before committing. There should be some kind of unit test accompanying each change. It would probably be a test within the packageService or bindings.

@neerajmandal neerajmandal changed the title fixed: issue fixed to generate the right function.json for event hub trigger fix: issue fixed to generate the right function.json for event hub trigger Aug 6, 2019
@neerajmandal neerajmandal changed the title fix: issue fixed to generate the right function.json for event hub trigger fix: issue fixed to generate the right function.json for event hub and service bus queue and topic triggers Aug 7, 2019
@neerajmandal neerajmandal changed the title fix: issue fixed to generate the right function.json for event hub and service bus queue and topic triggers fix: issue fixed to generate the correct function.json for event hub and service bus queue and topic triggers Aug 7, 2019
wbreza
wbreza approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Added 1 minor comment.

src/shared/bindings.json Outdated Show resolved Hide resolved
@wbreza
Copy link
Member

wbreza commented Aug 7, 2019

@njm3754 - Please make sure you associate the github issues with this fix.

@wbreza
Copy link
Member

wbreza commented Aug 7, 2019

Resolves issue #57

tbarlow12
tbarlow12 approved these changes Aug 7, 2019
View reviewed changes
Copy link
Collaborator

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neerajmandal neerajmandal merged commit 4e46a03 into dev Aug 7, 2019
tbarlow12 pushed a commit that referenced this pull request Sep 13, 2019
@neerajmandal @tbarlow12
fix: issue fixed to generate the correct function.json for event hub …
79a2576 
…and service bus queue and topic triggers (#228)

* fixed: issue fixed to create the right function.json for event hub trigger

* fix: wrong bindings issue for servicebus topic and queue added

* Test cases added

* Test cases added

* eventhubame to eventHubName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbreza wbreza wbreza approved these changes

@tbarlow12 tbarlow12 tbarlow12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@neerajmandal @coveralls @wbreza @tbarlow12