fix: Clean up .serverless folder before packaging new artifact #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #275 +/- ##
====================================
Coverage ? 89%
====================================
Files ? 47
Lines ? 1664
Branches ? 230
====================================
Hits ? 1481
Misses ? 183
Partials ? 0
Continue to review full report at Codecov.
|
wbreza
approved these changes
Aug 28, 2019
src/plugins/azureBasePlugin.ts
Outdated
|
|
||
| public constructor( | ||
| protected serverless: Serverless, | ||
| protected options: TOptions, | ||
| ) { | ||
| Guard.null(serverless); | ||
| this.originalCommand = (serverless as any as ServerlessObject).processedInput.commands[0] |
There was a problem hiding this comment.
Consider just calling this commands and keep the whole array of commands vs only pulling the first value in the event we may need more later?
tbarlow12
force-pushed
the
tabarlow/clean-up-sls
branch
from
0889174
to
35326cd
Compare
mydiemho
requested changes
Aug 28, 2019
| runtime: string; | ||
| } | ||
|
|
||
| export interface ServerlessObject { |
| config: ServerlessConfig; | ||
| } | ||
|
|
||
| export enum ServerlessCliCommand { |
There was a problem hiding this comment.
I thought jsdoc syntax was documenting interface members outside and not inline?
| LIST = "list", | ||
| } | ||
|
|
||
| export interface ServerlessConfig { |
|
|
||
| export interface ServerlessConfig { | ||
| servicePath: string; | ||
| packagePath: string; | ||
| } | ||
|
|
||
| export interface ServerlessAzureConfig { |
tbarlow12
force-pushed
the
tabarlow/clean-up-sls
branch
from
35326cd
to
81d204e
Compare
mydiemho
approved these changes
Aug 29, 2019
tbarlow12
force-pushed
the
tabarlow/clean-up-sls
branch
from
81d204e
to
cbaf516
Compare
tbarlow12
force-pushed
the
tabarlow/clean-up-sls
branch
from
cbaf516
to
da21d8c
Compare
tbarlow12
added a commit
that referenced
this pull request
Aug 30, 2019
tbarlow12
added a commit
that referenced
this pull request
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up
.serverlessfolder unless the package plugin is being executed from adeploycommand in which the--packageoption was included (don't want to remove a package the user is trying to deploy).Resolves #255