Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix compiler errors and remove logs plugin #286

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

tbarlow12
Copy link
Collaborator

@tbarlow12 tbarlow12 commented Aug 29, 2019

Not sure how these compiler errors snuck in here.

And although the logs plugin could be useful in the future, we don't currently support it. Also, removing the AzureProvider caused compiler errors in the logs plugin. Wasn't worth fixing since we don't support it

Copy link
Collaborator

@PIC123 PIC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tbarlow12 tbarlow12 merged commit 90f71a9 into dev Aug 29, 2019
@tbarlow12 tbarlow12 deleted the tabarlow/fix-compiler-error branch August 29, 2019 22:39
tbarlow12 added a commit that referenced this pull request Aug 30, 2019
release: Update prerelease version to 1.0.0-12 ***NO_CI***

release: Update prerelease version to 1.0.0-13 ***NO_CI***

release: Update prerelease version to 1.0.0-14 ***NO_CI***

release: Update prerelease version to 1.0.0-15 ***NO_CI***

release: Update prerelease version to 1.0.0-16 ***NO_CI***

release: Update prerelease version to 1.0.0-17 ***NO_CI***

release: Update prerelease version to 1.0.0-18 ***NO_CI***

release: Update prerelease version to 1.0.0-19 ***NO_CI***

release: Update prerelease version to 1.0.0-20 ***NO_CI***

release: Update prerelease version to 1.0.0-21 ***NO_CI***

release: Update prerelease version to 1.0.0-22 ***NO_CI***

release: Update prerelease version to 1.0.0-23 ***NO_CI***

release: Update prerelease version to 1.0.0-24 ***NO_CI***

release: Update prerelease version to 1.0.0-25 ***NO_CI***
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants