feat: Prompt user for confirmation to remove resource group #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarlow12
force-pushed
the
tabarlow/confirm-remove
branch
from
2ba7416
to
bf3656c
Compare
tbarlow12
force-pushed
the
tabarlow/confirm-remove
branch
from
bf3656c
to
e8ad154
Compare
wbreza
approved these changes
Oct 22, 2019
PIC123
approved these changes
Oct 25, 2019
pjlittle
reviewed
Oct 25, 2019
| this.log(`Resource group "${rgName}" does not exist in your Azure subscription`) | ||
| return; | ||
| } | ||
| this.log(`This command will delete your entire resource group (${resourceService.getResourceGroupName()}). ` + |
There was a problem hiding this comment.
nit: can we update the message to indicate something like: "This command will delete your ENTIRE resource group and ALL the Azure resources that it contains."
Just to explicitly call out that all resources will get nuked, not just things created by the sls framework.
|
Minor comment, otherwise looks great. Thx for adding this! |
pjlittle
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Requires user to enter resource group name as confirmation for group removal
Closes #380
How did you implement it:
How can we verify it:
sls removeand then just typeEnter(empty string shouldn't match), removal won't happensls removeand then type exact resource group name and removal will happenTodos:
Note: Run
npm run test:cito run all validation checks on proposed changesValidate via
npm run lintNote: Some reported issues can be automatically fixed by running
npm run lint:fixValidate via
npm testIs this ready for review?: YES
Is it a breaking change?: NO