feat: Eliminate need for 'x-azure-settings' config #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarlow12
requested review from
wbreza and
mydiemho
and removed request for
wbreza
wbreza
approved these changes
Mar 6, 2020
| return functionConfig.events.find((event) => { | ||
| const settings = event["x-azure-settings"] | ||
| const settings = Utils.get(event, constants.xAzureSettings, event); |
There was a problem hiding this comment.
Consider reusing this constant in other places where the raw text is still duplicated.
src/test/mockFactory.ts
Outdated
| @@ -334,15 +334,15 @@ export class MockFactory { | |||
| }; | |||
| } | |||
|
|
|||
| public static createTestFunctionMetadata(name: string): ServerlessAzureFunctionConfig { | |||
| public static createTestFunctionMetadata(name: string, xAzureSettings: boolean = true): ServerlessAzureFunctionConfig { | |||
There was a problem hiding this comment.
Seems a little messy to add a new param to all these mock methods special for the xAzureSettings case. Maybe consider creating new mock method for testing?
tbarlow12
force-pushed
the
tabarlow/x-azure-settings
branch
from
c66f41f
to
f484d43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Users can now place the configuration in the event object rather than inside the nested
x-azure-settingsconfiguration. Users can still usex-azure-settingsif they want. This is NOT a breaking changeCloses #371 and #12
How did you implement it:
x-azure-settingsto be optional member of interfacex-azure-functionsis defined on the event object. If it is not, the event itself is used.How can we verify it:
x-azure-settingsup one level and runsls offline. The bindings are generated correctlyTodos:
Note: Run
npm run test:cito run all validation checks on proposed changesValidate via
npm run lintNote: Some reported issues can be automatically fixed by running
npm run lint:fixValidate via
npm testIs this ready for review?: YES
Is it a breaking change?: NO