Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AWS EventBridge): Allow intrinsic functions in pattern #10120

Merged
merged 1 commit into from Oct 20, 2021

Conversation

bboure
Copy link
Contributor

@bboure bboure commented Oct 20, 2021

Fixes #9293

allows for event bridge patterns using intrinsic functions, like this one:

    events:
      - eventBridge:
          pattern:
            account:
              - !Sub ${AWS::AccountId}

Note: This will only work when using CloudFormtion

eventBridge:
    useCloudFormation: true

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #10120 (cdd7f26) into master (a8d1713) will decrease coverage by 0.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10120      +/-   ##
==========================================
- Coverage   86.16%   85.27%   -0.89%     
==========================================
  Files         329      335       +6     
  Lines       13057    13687     +630     
==========================================
+ Hits        11250    11671     +421     
- Misses       1807     2016     +209     
Impacted Files Coverage Δ
...ns/aws/package/compile/events/eventBridge/index.js 98.34% <100.00%> (-0.04%) ⬇️
lib/plugins/aws/metrics.js 57.97% <0.00%> (-42.03%) ⬇️
lib/classes/CLI.js 60.00% <0.00%> (-31.43%) ⬇️
lib/plugins/print.js 71.21% <0.00%> (-28.79%) ⬇️
lib/plugins/aws/deployList.js 71.42% <0.00%> (-20.24%) ⬇️
lib/cli/handle-error.js 81.08% <0.00%> (-7.58%) ⬇️
lib/plugins/standalone.js 40.74% <0.00%> (-5.78%) ⬇️
lib/utils/processBackendNotificationRequest.js 44.44% <0.00%> (-5.56%) ⬇️
lib/cli/interactive-setup/deploy.js 86.15% <0.00%> (-5.08%) ⬇️
lib/cli/interactive-setup/utils.js 84.31% <0.00%> (-4.82%) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d1713...cdd7f26. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bboure, looks great 🙇

@pgrzesik pgrzesik changed the title fix(AWS EventBridge): Allow intrinsic functions in pattern fix(AWS EventBridge): Allow intrinsic functions in pattern Oct 20, 2021
@pgrzesik pgrzesik merged commit 1c105a4 into serverless:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: use intrinsic functions in eventbridge detail pattern
2 participants