Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Recognize Fn::Select in environment config schema #11114

Conversation

Johnogram
Copy link
Contributor

@Johnogram Johnogram commented May 25, 2022

Closes: #11109

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #11114 (17a98e0) into main (497529a) will not change coverage.
The diff coverage is n/a.

❗ Current head 17a98e0 differs from pull request most recent head 95cff78. Consider uploading reports for the commit 95cff78 to get more accurate results

@@           Coverage Diff           @@
##             main   #11114   +/-   ##
=======================================
  Coverage   86.04%   86.04%           
=======================================
  Files         315      315           
  Lines       13274    13274           
=======================================
  Hits        11422    11422           
  Misses       1852     1852           
Impacted Files Coverage Δ
lib/plugins/aws/provider.js 94.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 497529a...95cff78. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, thank you @Johnogram 🙇

@pgrzesik pgrzesik changed the title feat: Add Select Intrinsic function to environment config schema fix: Recognize Fn::Select in environment config schema May 26, 2022
@pgrzesik pgrzesik merged commit ed111e0 into serverless:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration validation fails when I use Fn::Join
2 participants