You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched existing issues, it hasn't been reported yet
Use case description
Currently, serverless automatically includes @serverless/dashboard-plugin and probably other libraries only needed when using enterprise feature. The user should be able to opt-in to this instead of having it installed regardless of whether it will be used or not.
Furthermore, the dashboard plugin is always installed last. So, it's impossible to do anything in the plugin that should be executed after the dashboard plugin
Proposed solution (optional)
Ideally, all enterprise features should not be include by default. You could, for example, use a peer-dependency @serverless/enterprise that the user can install to pull in all enterprise features and libraries.
Furthermore, the dashboard plugin should be declared like any other plugin so you can decide in which order it runs.
The text was updated successfully, but these errors were encountered:
Hey @juanjoDiaz - thanks for reporting. I see the reasoning behind your suggestion, I believe the way it is set up right now was introduced out of convenience to not require users to explicitly include the plugin. Also, there are some changes already introduced for Serverless Console where the setup happens a bit differently (without additional plugin).
Is there anything that was made harder due to the fact that plugin is introduced? It shouldn't really impact anything if Dashboard integration is not enabled.
Serverless dashboard currently conflicts with one of my plugins: juanjoDiaz/serverless-plugin-warmup#310.
I'm pretty sure it also conflicts with my middleware plugin and there are just no dashboard users using that plugin.
However, I can see this lack of flexibility in the order that the plugins are added if you want to create a plugin that does something after the dashboard wrapper has been applied.
Also, on a more philosophical thinking, serverless shouldn't download stuff that is not needed nor used by the user.
I know that the whole npm is build in a way that every time that you add a dependency, a million packages get added.
But we, as package authors, should try to minimize this.
Is there an existing issue for this?
Use case description
Currently, serverless automatically includes
@serverless/dashboard-plugin
and probably other libraries only needed when using enterprise feature. The user should be able to opt-in to this instead of having it installed regardless of whether it will be used or not.Furthermore, the dashboard plugin is always installed last. So, it's impossible to do anything in the plugin that should be executed after the dashboard plugin
Proposed solution (optional)
Ideally, all enterprise features should not be include by default. You could, for example, use a peer-dependency
@serverless/enterprise
that the user can install to pull in all enterprise features and libraries.Furthermore, the dashboard plugin should be declared like any other plugin so you can decide in which order it runs.
The text was updated successfully, but these errors were encountered: