Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AWS Lambda): Add support for consumer group ID to kafka event #11345

Conversation

Phil-Pinkowski
Copy link
Contributor

@Phil-Pinkowski Phil-Pinkowski commented Aug 18, 2022

Context: this has just been added to the event trigger as a feature and is an extremely useful missing feature: https://aws.amazon.com/about-aws/whats-new/2022/08/aws-lambda-consumer-group-ids-msk-kafka-event-sources/

Closes: (No issue created yet for this)

@mnapoli
Copy link
Contributor

mnapoli commented Aug 22, 2022

Hi, just a heads up: unfortunately at the time we will not have the capacity to provide guidance or review a PR implementing that feature. Sorry that I'm not able to help more with this!

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #11345 (70e28d4) into main (076661f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 70e28d4 differs from pull request most recent head db0554a. Consider uploading reports for the commit db0554a to get more accurate results

@@           Coverage Diff           @@
##             main   #11345   +/-   ##
=======================================
  Coverage   85.84%   85.85%           
=======================================
  Files         314      314           
  Lines       13248    13253    +5     
=======================================
+ Hits        11373    11378    +5     
  Misses       1875     1875           
Impacted Files Coverage Δ
lib/plugins/aws/package/compile/events/kafka.js 98.64% <100.00%> (+0.03%) ⬆️
...ib/plugins/aws/package/compile/events/msk/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@awitterackspace
Copy link

+1 for this feature.

@mnapoli thanks for the update; any idea on when you'll have capacity to add this feature?

@mnapoli
Copy link
Contributor

mnapoli commented Aug 22, 2022

Unfortunately I'm not able to provide a timeline.

@simonarcher99
Copy link
Contributor

+1 for this issue as well

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, it would be great to add it to msk event as well for completeness - in the current form it will only work for self-manager Kafka clusters

lib/plugins/aws/package/compile/events/kafka.js Outdated Show resolved Hide resolved
@king-freshket
Copy link

+1 for this feature

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @Phil-Pinkowski 👍 It will probably need another review from @mnapoli or @medikoo before merging though.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Phil-Pinkowski ! That looks great

Great thanks @pgrzesik for help in pushing it forward

@medikoo medikoo merged commit 9bb3f11 into serverless:main Aug 26, 2022
@Phil-Pinkowski Phil-Pinkowski deleted the add-consumer-group-id-kafka-event-config branch August 26, 2022 10:15
@nick-zh nick-zh mentioned this pull request Oct 28, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants