New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AWS Lambda): Add support for consumer group ID to kafka event #11345
feat(AWS Lambda): Add support for consumer group ID to kafka event #11345
Conversation
Hi, just a heads up: unfortunately at the time we will not have the capacity to provide guidance or review a PR implementing that feature. Sorry that I'm not able to help more with this! |
Codecov Report
@@ Coverage Diff @@
## main #11345 +/- ##
=======================================
Coverage 85.84% 85.85%
=======================================
Files 314 314
Lines 13248 13253 +5
=======================================
+ Hits 11373 11378 +5
Misses 1875 1875
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
+1 for this feature. @mnapoli thanks for the update; any idea on when you'll have capacity to add this feature? |
Unfortunately I'm not able to provide a timeline. |
+1 for this issue as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, it would be great to add it to msk
event as well for completeness - in the current form it will only work for self-manager Kafka clusters
+1 for this feature |
…event and update docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @Phil-Pinkowski 👍 It will probably need another review from @mnapoli or @medikoo before merging though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Phil-Pinkowski ! That looks great
Great thanks @pgrzesik for help in pushing it forward
Context: this has just been added to the event trigger as a feature and is an extremely useful missing feature: https://aws.amazon.com/about-aws/whats-new/2022/08/aws-lambda-consumer-group-ids-msk-kafka-event-sources/
Closes: (No issue created yet for this)