Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 serverlessdeploymentbucket default setting best practices #11353

Open
1 task done
aran112000 opened this issue Aug 24, 2022 · 0 comments
Open
1 task done

S3 serverlessdeploymentbucket default setting best practices #11353

aran112000 opened this issue Aug 24, 2022 · 0 comments

Comments

@aran112000
Copy link

aran112000 commented Aug 24, 2022

Is there an existing issue for this?

  • I have searched existing issues, it hasn't been reported yet

Use case description

We recently spotted that the S3 deployment buckets created by Serverless Framework that holds the deployed code & CloudFormation templates are failing some of the AWS Security Hub S3 checks. Namely, public access isn't explicitly enabled, although this is achieved via the policy template anyway.

Has this intentionally been left out of the default S3 template? If not, happy to submit a PR to resolve this.

AWS recommendation:
https://docs.aws.amazon.com/securityhub/latest/userguide/securityhub-standards-fsbp-controls.html#fsbp-s3-1

Relevant template
https://github.com/serverless/serverless/blob/bf79934e9b43a0b2e8613ee29f9430fa22c41481/lib/plugins/aws/package/lib/core-cloudformation-template.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant