New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 11402 add in a try catch block for copy of the healthcheck #11403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @THOM-AwS! Still please see my comments, we need to stick to the codebase conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@THOM-AwS looks very good! Just two more updates and we're good to go
Codecov ReportBase: 85.85% // Head: 85.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #11403 +/- ##
==========================================
- Coverage 85.85% 85.83% -0.02%
==========================================
Files 314 314
Lines 13253 13257 +4
==========================================
+ Hits 11378 11379 +1
- Misses 1875 1878 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@THOM-AwS great thanks, all looks good now.
There's just one purely stylistic issue left. Proposed changes do not match Prettier formatting (see CI fail). You can fix it by running npm run prettify:updated
in context of your branch
Done Sir. Thanks for the assistance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @THOM-AwS !
Closes: #11402
@medikoo