Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 11402 add in a try catch block for copy of the healthcheck #11403

Merged
merged 7 commits into from Sep 22, 2022

Conversation

THOM-AwS
Copy link
Contributor

Closes: #11402
@medikoo

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @THOM-AwS! Still please see my comments, we need to stick to the codebase conventions

lib/utils/log-deprecation.js Outdated Show resolved Hide resolved
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@THOM-AwS looks very good! Just two more updates and we're good to go

lib/utils/log-deprecation.js Outdated Show resolved Hide resolved
lib/utils/log-deprecation.js Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 85.85% // Head: 85.83% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (64cfc75) compared to base (93ce41e).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11403      +/-   ##
==========================================
- Coverage   85.85%   85.83%   -0.02%     
==========================================
  Files         314      314              
  Lines       13253    13257       +4     
==========================================
+ Hits        11378    11379       +1     
- Misses       1875     1878       +3     
Impacted Files Coverage Δ
lib/utils/log-deprecation.js 81.57% <40.00%> (-3.15%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@THOM-AwS great thanks, all looks good now.

There's just one purely stylistic issue left. Proposed changes do not match Prettier formatting (see CI fail). You can fix it by running npm run prettify:updated in context of your branch

@THOM-AwS
Copy link
Contributor Author

THOM-AwS commented Sep 22, 2022

@THOM-AwS great thanks, all looks good now.

There's just one purely stylistic issue left. Proposed changes do not match Prettier formatting (see CI fail). You can fix it by running npm run prettify:updated in context of your branch

Done Sir. Thanks for the assistance.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @THOM-AwS !

@medikoo medikoo merged commit b95c749 into serverless:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serverless deploy in GitHub Actions fails with copy error
2 participants