New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extend AWS provider schema to support Fn::ToJsonString in environment variable #11461
feat: Extend AWS provider schema to support Fn::ToJsonString in environment variable #11461
Conversation
Codecov ReportBase: 85.79% // Head: 85.79% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #11461 +/- ##
=======================================
Coverage 85.79% 85.79%
=======================================
Files 314 314
Lines 13259 13259
=======================================
Hits 11375 11375
Misses 1884 1884
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
First of all, thank you so much for this PR! I'm really looking forward to seeing this land. This may be out of scope, and not something I really need myself. But just wanted to raise it as a topic of interest. Environment variables inevitably will not be the only place where this will be useful. For example, when crafting a CloudWatch Dashboard under Resources, ToJsonString would allow people to use YAML to define a dashboard and have it convert to an unwieldy JSON string through this method. MyDashboard:
Type: AWS::CloudWatch::Dashboard
Properties:
DashboardName: MyDashboard
DashboardBody: !ToJsonString
etc: This is the best example I could come up with, but can imagine there may be more places where people may want to use ToJsonString in their resources-section. Or is this perhaps a non-issue because nothing is enforced under |
@ronkorving I think nothing is enforced under Maybe someone that's deeper into the framework can confirm that. |
@medikoo Coverage failed, but on code I didn't touch. Is there something I can do to fix this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jurriaanpro It looks good. Please see my comments
@medikoo I've applied the suggested changes. Could you check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jurriaanpro can you rebase with main branch? I wonder why no github actions were not run - feels as GitHub quirk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Closes: #11409