Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback jackson-databind version to 2.11.0 #11589

Merged
merged 1 commit into from Dec 12, 2022

Conversation

gdenning
Copy link
Contributor

@gdenning gdenning commented Dec 8, 2022

Closes: #11588

The build is currently failing with this error:

```
mvn(stdout) - [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project invoke-bridge: Compilation failure
mvn(stdout) - [ERROR] /Users/geoff.denning/.serverless/artifacts/3.25.1/runtime-wrappers/java/src/test/java/com/serverless/RequestStreamHandler.java:[19,28] cannot access com.fasterxml.jackson.core.exc.StreamWriteException
mvn(stdout) - [ERROR]   class file for com.fasterxml.jackson.core.exc.StreamWriteException not found
```

This change resolves the build-time error by making the `jackson-databind` version consistent with the other `jackson` dependencies.
@medikoo
Copy link
Contributor

medikoo commented Dec 9, 2022

@pen4 it appears that the change introduced with #11535 broke the local invocation for Java. Can you comment on that?

@medikoo
Copy link
Contributor

medikoo commented Dec 12, 2022

No response from @pen4, let's move forward with it

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 85.63% // Head: 85.63% // No change to project coverage 👍

Coverage data is based on head (611b46b) compared to base (e791e04).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11589   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files         315      315           
  Lines       13134    13134           
=======================================
  Hits        11247    11247           
  Misses       1887     1887           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@medikoo medikoo merged commit f00eb82 into serverless:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java bridge (invoke-bridge) build is failing in version 3.25.1 due to mismatched Jackson dependencies
2 participants