Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error filesize@10.0.5: The engine "node" is incompatible with this module. Expected version ">= 14.0.0". Got "12.22.10" #11594

Closed
4 tasks done
0xdevalias opened this issue Dec 12, 2022 · 3 comments

Comments

@0xdevalias
Copy link

Are you certain it's a bug?

  • Yes, it looks like a bug

Is the issue caused by a plugin?

  • It is not a plugin issue

Are you using the latest v3 release?

  • Yes, I'm using the latest v3 release

Is there an existing issue for this?

  • I have searched existing issues, it hasn't been reported yet

Issue description

When using node version v12.22.10, installing any version after serverless@3.22.0 with yarn (or another package manager that respects the engines key in package.json) will error with the following:

error filesize@10.0.5: The engine "node" is incompatible with this module. Expected version ">= 14.0.0". Got "12.22.10"
error Found incompatible module.

This is due to the filesize bump from version 8.0.7 to version 10.0.5 introduced in:

I know that node v12 is EOL as of April 30 2022, so I don't really expect it to continue being supported. I mostly just wanted to document this here in case it helps anyone else in future, as there was no 'Breaking Change' notes documenting this in the CHANGELOG / release notes that I could see.

Service configuration (serverless.yml) content

N/A

Command name and used flags

N/A

Command output

N/A

Environment information

N/A
@medikoo
Copy link
Contributor

medikoo commented Dec 12, 2022

@0xdevalias great thanks for report. Yet, it might be an error on filesize side. See avoidwork/filesize.js#168 and avoidwork/filesize.js#161

Before taking that in, let's wait for final confirmation from them

@medikoo
Copy link
Contributor

medikoo commented Dec 12, 2022

@0xdevalias filesize acknowledged it as a bug in their metadata, and fixed that. v10 is safe to use in Node.js v12. I'm closing it then.

@medikoo medikoo closed this as completed Dec 12, 2022
@0xdevalias
Copy link
Author

0xdevalias commented Dec 13, 2022

@medikoo Amazing! Thanks for checking and following up on this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants