Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sources defined empty env vars #11629

Merged
merged 1 commit into from Dec 21, 2022

Conversation

jasonrowsell
Copy link
Contributor

Closes: #11455

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jasonrowsell, it looks great!

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 85.86% // Head: 85.86% // No change to project coverage 👍

Coverage data is based on head (6f15fef) compared to base (968ddd5).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 6f15fef differs from pull request most recent head 40f9236. Consider uploading reports for the commit 40f9236 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11629   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files         315      315           
  Lines       13191    13191           
=======================================
  Hits        11327    11327           
  Misses       1864     1864           
Impacted Files Coverage Δ
lib/configuration/variables/sources/env.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jasonrowsell
Copy link
Contributor Author

@medikoo Ready to merge :) Hopefully the Stale PR and Issue can be closed after merging 👍

@medikoo medikoo merged commit 022db9c into serverless:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty string environment variable value treated as missing
2 participants