Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SnapStart for Websocket and Scheduled executions #11662

Closed
1 task done
rnielsen opened this issue Jan 6, 2023 · 1 comment · Fixed by #11788
Closed
1 task done

Support SnapStart for Websocket and Scheduled executions #11662

rnielsen opened this issue Jan 6, 2023 · 1 comment · Fixed by #11788

Comments

@rnielsen
Copy link
Contributor

rnielsen commented Jan 6, 2023

Is there an existing issue for this?

  • I have searched existing issues, it hasn't been reported yet

Use case description

When snapStart:true is turned on for a function, the "snapstart" alias is used when calling the lambda from the events "http", "stream" and "sqs" but the $LATEST version is used for "websocket" (and the associated authorizer) and "scheduled" events so the SnapStart feature isn't used. There may be other unsupported events but these are the ones I have noticed.

I can work around this by overriding the CloudFormation in resources/extensions but it seems like it should be supported natively.

Proposed solution (optional)

When using snapStart:true on a function, all events attached to that function should invoke the "snapstart" alias.

@medikoo
Copy link
Contributor

medikoo commented Jan 9, 2023

@rnielsen this looks as a bug, that should be fixed. We should resolve correct alias in case of websocket as we do in case of other type of events. PR's welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants