Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed Map for runtimeManagementMap #11778

Merged
merged 2 commits into from Mar 7, 2023
Merged

fix: Changed Map for runtimeManagementMap #11778

merged 2 commits into from Mar 7, 2023

Conversation

KillDozerX2
Copy link
Contributor

It was not in sync with Cloudformation, could be Cloudformation is wrong, just syncing this with CF. Here's the link to the documentation:- https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-function-runtimemanagementconfig.html#cfn-lambda-function-runtimemanagementconfig-updateruntimeon

Fix for PR #11715

@KillDozerX2
Copy link
Contributor Author

Forgot to update the test. Updating the test now.

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e872787) 86.56% compared to head (8f511b5) 86.56%.

❗ Current head 8f511b5 differs from pull request most recent head ae15d4e. Consider uploading reports for the commit ae15d4e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11778   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files         314      314           
  Lines       13127    13127           
=======================================
  Hits        11363    11363           
  Misses       1764     1764           
Impacted Files Coverage Δ
lib/plugins/aws/package/compile/functions.js 95.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @KillDozerX2 !

@medikoo medikoo merged commit 8db2f4c into serverless:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants