New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Description property to EventBridge rules #11821
Add support for Description property to EventBridge rules #11821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @anthonyroussel, that looks very good!
The only thing we're missing here, is documentation, which best if added at:
https://github.com/serverless/serverless/blob/f606014e033330ea746cec0141cbaf1d5f556e60/docs/providers/aws/guide/serverless.yml.md
515861d
to
36b38e1
Compare
Hello @medikoo. Thanks for the review. I have added some documentation about the Description field in docs/providers/aws/guide/serverless.yml.md. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anthonyroussel unfortunately CI is failing with lint error, can you check that?
36b38e1
to
9781225
Compare
Ooops sorry! I fixed the test. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11821 +/- ##
=======================================
Coverage 85.67% 85.67%
=======================================
Files 316 316
Lines 13342 13343 +1
=======================================
+ Hits 11431 11432 +1
Misses 1911 1911
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Add support for Description property to EventBridge rules