Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong alb ip condition validation #11889

Merged
merged 3 commits into from Jun 9, 2023
Merged

Conversation

Inqnuam
Copy link
Contributor

@Inqnuam Inqnuam commented Apr 3, 2023

Closes: #11883

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Inqnuam that looks great, can we back it with test that confirms that CIDR format is passed ?

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4582913) 86.70% compared to head (e000afb) 86.71%.

❗ Current head e000afb differs from pull request most recent head 55baef5. Consider uploading reports for the commit 55baef5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11889   +/-   ##
=======================================
  Coverage   86.70%   86.71%           
=======================================
  Files         316      316           
  Lines       13514    13514           
=======================================
+ Hits        11717    11718    +1     
+ Misses       1797     1796    -1     
Impacted Files Coverage Δ
...ib/plugins/aws/package/compile/events/alb/index.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Inqnuam Inqnuam requested a review from medikoo June 8, 2023 04:30
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Inqnuam 👍

@medikoo medikoo merged commit 04db0f0 into serverless:main Jun 9, 2023
5 checks passed
khacminh pushed a commit to khacminh/serverless that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong ALB event ip condition validation
2 participants