Update .NET runtimes #11960
Update .NET runtimes #11960
Conversation
…)" This reverts commit 314f32c.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11960 +/- ##
==========================================
+ Coverage 86.68% 86.73% +0.04%
==========================================
Files 316 316
Lines 13440 13504 +64
==========================================
+ Hits 11651 11713 +62
- Misses 1789 1791 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@slang25 great thanks for this PR.
Still can you fully (in the context of this PR) provide a reason for this change?
Also, can you weight on the comment submitted by @GrahamCampbell (suggestion is to remove also dotnetcore3.1 from a list)
|
Actually, I think this should be closed. Their docs on GitHub are not maintained. Their public docs website is correct as far as I'm aware. |
|
I created a PR to the docs to fix them, but soon after AWS announced that they will no longer use GH for docs, so I've submitted it as feedback, and separately I'll be speaking with someone from AWS soon and will put this on their radar. The docs are wrong, but I appreciate that until the authoritative source is fixed then it's just some guys opinion 😆 |
|
While I try to get the docs fixed, @normj would you be able to confirm as an AWS employee working in this space |
|
As @slang25 mentioned I work at AWS specifically on the .NET team that partners with Lambda to provide the .NET support. I'm not sure I understand the full context of this PR but right now the only supported manage runtime for .NET in Lambda is .NET 6 ( |
@normj The docs show this is not yet phase 2 deprecated? Are the docs incorrect? |
|
@GrahamCampbell Yes .NET Core 3.1 is in phase 2 and the service is enforcing create and update function calls for .NET Core 3.1 be rejected. You get the following error message if you attempt to create a .NET Core 3.1 function. The docs haven't been updated yet but I know the team is working on getting that done. |
|
Perfect, in which case |
|
Thanks all, PR updated to reflect this discussion. |
There was a problem hiding this comment.
@slang25 @GrahamCampbell great thanks for figuring this out 👍
|
Pretty bad that the docs are so wrong on this then, I'd nearly set people to changing from the custom runtime to use .net 7 https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
|
|
@mungojam Not sure why that paged ever listed .NET 5 and 7. I opened an internal ticket with the docs team to get that fixed up. |
|
Thanks @normj, trying to fix the docs as an outsider has just resulted in radio silence as expected (that's not aimed at you, but AWS more generally!) |
|
@slang25 Thanks for pinging me in! |
|
The Lambda runtime doc page is updated listing only .NET 6 and .NET 7 container only. https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html |
Partly reverts #11941
This PR removes .NET Lambda runtimes that don't exist, and removes .NET Core 3.1 as it will now be rejected by AWS when trying to deploy.