New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix scheduler role #12030
fix scheduler role #12030
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12030 +/- ##
==========================================
- Coverage 86.70% 86.68% -0.03%
==========================================
Files 316 316
Lines 13513 13529 +16
==========================================
+ Hits 11717 11727 +10
- Misses 1796 1802 +6
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tie624! Can we have it accompanied with a regression test?
@medikoo I have added the test. |
@medikoo made a small change to continue to use default execution role if it exists. |
@tie624 when it's ready for re-review, please re-request review in reviewers box |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tie624 ! Please see my comments
test/unit/lib/plugins/aws/package/compile/events/schedule.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tie624 👍
Could this be released please? |
Fix the role for scheduler so that it matches the role of the function.
Closes #12022