Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scheduler role #12030

Merged
merged 4 commits into from Jun 28, 2023
Merged

fix scheduler role #12030

merged 4 commits into from Jun 28, 2023

Conversation

tie624
Copy link
Contributor

@tie624 tie624 commented Jun 19, 2023

Fix the role for scheduler so that it matches the role of the function.

Closes #12022

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 53.84% and project coverage change: -0.03 ⚠️

Comparison is base (17d64e6) 86.70% compared to head (7bde051) 86.68%.

❗ Current head 7bde051 differs from pull request most recent head 477e9f1. Consider uploading reports for the commit 477e9f1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12030      +/-   ##
==========================================
- Coverage   86.70%   86.68%   -0.03%     
==========================================
  Files         316      316              
  Lines       13513    13529      +16     
==========================================
+ Hits        11717    11727      +10     
- Misses       1796     1802       +6     
Impacted Files Coverage Δ
lib/utils/standalone.js 50.00% <16.66%> (-7.90%) ⬇️
lib/utils/eventually-update.js 29.20% <22.22%> (-0.16%) ⬇️
...ib/plugins/aws/package/compile/events/msk/index.js 100.00% <100.00%> (ø)
lib/plugins/aws/package/compile/events/schedule.js 97.87% <100.00%> (+0.04%) ⬆️
...ckage/compile/events/websockets/lib/authorizers.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tie624! Can we have it accompanied with a regression test?

@tie624
Copy link
Contributor Author

tie624 commented Jun 20, 2023

@medikoo I have added the test.

@tie624
Copy link
Contributor Author

tie624 commented Jun 27, 2023

@medikoo made a small change to continue to use default execution role if it exists.

@medikoo
Copy link
Contributor

medikoo commented Jun 27, 2023

@tie624 when it's ready for re-review, please re-request review in reviewers box

@tie624 tie624 requested a review from medikoo June 27, 2023 14:45
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tie624 ! Please see my comments

lib/plugins/aws/package/compile/events/schedule.js Outdated Show resolved Hide resolved
@tie624 tie624 requested a review from medikoo June 27, 2023 15:57
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tie624 👍

@medikoo medikoo merged commit e1039de into serverless:main Jun 28, 2023
5 checks passed
@mungojam
Copy link

mungojam commented Aug 3, 2023

Could this be released please?

khacminh pushed a commit to khacminh/serverless that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::Scheduler::Schedule events do not work with custom IAM Roles
3 participants