Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: recognize ap-south-2 as a valid AWS region #12129

Merged
merged 1 commit into from Sep 4, 2023
Merged

feat: recognize ap-south-2 as a valid AWS region #12129

merged 1 commit into from Sep 4, 2023

Conversation

amlodzianowski
Copy link
Contributor

Closes: #12128

@amlodzianowski amlodzianowski changed the title fix: recognize ap-south-2 as a valid AWS region feat: recognize ap-south-2 as a valid AWS region Aug 29, 2023
@amlodzianowski amlodzianowski mentioned this pull request Aug 29, 2023
Merged
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4288d69) 86.68% compared to head (2f72adb) 86.68%.

❗ Current head 2f72adb differs from pull request most recent head 64ddc4e. Consider uploading reports for the commit 64ddc4e to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #12129   +/-   ##
=======================================
  Coverage   86.68%   86.68%           
=======================================
  Files         316      316           
  Lines       13529    13529           
=======================================
  Hits        11727    11727           
  Misses       1802     1802
Files Changed Coverage Δ
lib/plugins/aws/provider.js 94.78% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Mmarzex
Mmarzex approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@Mmarzex Mmarzex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 👍

@Mmarzex Mmarzex merged commit b09d0d6 into serverless:main Sep 4, 2023
5 checks passed
khacminh pushed a commit to khacminh/serverless that referenced this pull request Nov 29, 2023
@amlodzianowski @khacminh
fix: recognize ap-south-2 as a valid AWS region (serverless#12129)
7f10e2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mmarzex Mmarzex Mmarzex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support AWS Asia Pacific (Hyderabad) / ap-south-2 region
2 participants
@amlodzianowski @Mmarzex