Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove Console Login #12153

Merged
merged 9 commits into from Sep 15, 2023
Merged

feat: Remove Console Login #12153

merged 9 commits into from Sep 15, 2023

Conversation

Mmarzex
Copy link
Contributor

@Mmarzex Mmarzex commented Sep 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.09% ⚠️

Comparison is base (6ee277d) 86.63% compared to head (5ceb851) 86.54%.

❗ Current head 5ceb851 differs from pull request most recent head f8bec7c. Consider uploading reports for the commit f8bec7c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12153      +/-   ##
==========================================
- Coverage   86.63%   86.54%   -0.09%     
==========================================
  Files         316      311       -5     
  Lines       13535    13121     -414     
==========================================
- Hits        11726    11356     -370     
+ Misses       1809     1765      -44     
Files Changed Coverage Δ
lib/cli/commands-schema/no-service.js 100.00% <ø> (ø)
lib/utils/telemetry/generate-payload.js 92.30% <ø> (ø)
scripts/serverless.js 70.28% <ø> (-0.51%) ⬇️
lib/cli/interactive-setup/utils.js 85.45% <33.33%> (+0.45%) ⬆️
commands/login.js 100.00% <100.00%> (+5.26%) ⬆️
lib/cli/interactive-setup/deploy.js 94.28% <100.00%> (-0.46%) ⬇️
lib/cli/interactive-setup/index.js 92.50% <100.00%> (+17.50%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mmarzex Mmarzex merged commit 590bb7e into main Sep 15, 2023
5 checks passed
@Mmarzex Mmarzex deleted the remove-console-login branch September 15, 2023 15:33
khacminh pushed a commit to khacminh/serverless that referenced this pull request Nov 29, 2023
* feat: Remove Console Login

* fix: Update login tests to remove console login options

* feat: Remove Console login options

* feat: Remove console onboarding

* fix: Remove console tests

* chore: Remove remaining console flags

* fix: Remove console deploy unit test

* fix: Interactive Setup tests

* fix: Update generate-payload tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant