Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust providers endpoint #12154

Merged
merged 3 commits into from Sep 15, 2023
Merged

fix: Adjust providers endpoint #12154

merged 3 commits into from Sep 15, 2023

Conversation

ac360
Copy link
Member

@ac360 ac360 commented Sep 15, 2023

Adjusts the Providers endpoint from websockets to polling.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.00% 🎉

Comparison is base (561a875) 85.62% compared to head (53c5c2a) 86.63%.
Report is 1 commits behind head on main.

❗ Current head 53c5c2a differs from pull request most recent head 4f9b307. Consider uploading reports for the commit 4f9b307 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12154      +/-   ##
==========================================
+ Coverage   85.62%   86.63%   +1.00%     
==========================================
  Files         317      316       -1     
  Lines       13726    13536     -190     
==========================================
- Hits        11753    11727      -26     
+ Misses       1973     1809     -164     
Files Changed Coverage Δ
lib/plugins/deploy.js 84.21% <ø> (+7.28%) ⬆️
lib/cli/interactive-setup/aws-credentials.js 83.16% <100.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mmarzex Mmarzex merged commit 9b770a2 into main Sep 15, 2023
5 checks passed
@Mmarzex Mmarzex deleted the adjust-providers-endpoint branch September 15, 2023 15:34
khacminh pushed a commit to khacminh/serverless that referenced this pull request Nov 29, 2023
* fix: Fiormatting

* feat: Remove Dashboard onboarding from framework (serverless#12151)

* fix: Providers test

---------

Co-authored-by: Max Marze <max@marze.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants