Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old API-GW stages aren't cleaned up during deployment. #12355

Open
4 tasks done
richkifvel opened this issue Feb 15, 2024 · 0 comments
Open
4 tasks done

Old API-GW stages aren't cleaned up during deployment. #12355

richkifvel opened this issue Feb 15, 2024 · 0 comments

Comments

@richkifvel
Copy link

Are you certain it's a bug?

  • Yes, it looks like a bug

Is the issue caused by a plugin?

  • It is not a plugin issue

Are you using the latest v3 release?

  • Yes, I'm using the latest v3 release

Is there an existing issue for this?

  • I have searched existing issues, it hasn't been reported yet

Issue description

We made a change to one of our function event paths in our serverless config by adding in {proxy+}
eg:

events:
      - http:
          method: post
          path: api/path

... became...

events:
      - http:
          method: post
          path: api/path/{proxy+}

We found that when this change was deployed to testing accounts, checking in AWS API-GW stages, the old path wasn't removed and the new one was added, which resulted in our tests succeeding.
However when this change was deployed to other accounts the old path had been removed leaving just the new proxy path. We are getting two very different behaviors here, sadly the former resulted in this endpoint not working properly. Do you know what the expected behavior is and if this change should be removing the old path in API-GW stage?

Service configuration (serverless.yml) content

N/A

Command name and used flags

serverless deploy --conceal --verbose

Command output

N/A

Environment information

"serverless": "^3.33.0",
    "serverless-plugin-resource-tagging": "^1.2.0",
    "serverless-plugin-datadog": "^5.33.0",
    "serverless-apigateway-service-proxy": "^2.2.1"

I updated serverless to 3.38.0 and was able to see the same behavior where the old path wasn't removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant