Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest release broke install.sh on v3 #12522

Closed
arsham-f opened this issue May 22, 2024 · 3 comments
Closed

The latest release broke install.sh on v3 #12522

arsham-f opened this issue May 22, 2024 · 3 comments

Comments

@arsham-f
Copy link

Issue description

install.sh on v3: https://github.com/serverless/serverless/blob/v3/scripts/pkg/install.sh

By default, it will detect the latest version on line 62:

TAG=`curl -L --silent https://api.github.com/repos/serverless/serverless/releases/latest 2>&1 | grep 'tag_name' | grep -oE "v[0-9]+\.[0-9]+\.[0-9]+"`

The regex expects the latest version number to start with a v. However the release that was just posted (https://github.com/serverless/serverless/releases/tag/4.0.24) does not have the v prefix. So this script is crashing.

Context

N/A

@austencollins
Copy link
Member

austencollins commented May 22, 2024

Thanks @arsham-f. We're removing the release while we fix that script, ensuring it only points to v3 release and not v4 releases,

@austencollins
Copy link
Member

This fixed the issue temporarily. Fixing the script next to avoid this in the future and unblock Github releases

@arsham-f
Copy link
Author

Thank you. Confirmed it's working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants