Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force project.json project name and s-project.json name to match #1323

Closed
jthomerson opened this issue Jun 14, 2016 · 2 comments
Closed

Comments

@jthomerson
Copy link
Contributor

It seems unnecessary to enforce that the project name in s-project.json be the same as package.json. I shouldn't necessarily need to publish under npm (the purpose of package.json) with exactly the same name that I create the resources in AWS with (the purpose of the name in s-project.json).

Tangentially, it's strange to me that SLS rewrites package.json at all since package.json is a file for NPM, not SLS. It should maybe read values from package.json, but not necessarily write anything there. Can that be considered?

@mikelax
Copy link
Contributor

mikelax commented Jun 17, 2016

I agree with this. I can't think of a reason why package.json would need to be modified at all by any sls commands.

@flomotlik
Copy link
Contributor

Hi, thank you for reaching out to us! At this point we've stopped working on 0.5 of Serverless to fully focus on V1.0 that we're currently working on. Therefore we're not taking any changes for 0.5 and do not plan any future releases at this point. We only have a limited set of resources and just need to make sure we're putting everything we have into our next release (and can provide great long term support and backwards compatibility from then on). Hope you understand.

We would love to get your feedback on V1 of the framework and I'm happy to walk you through any questions to make sure its all working great for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants