Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included devDependencies causes warning when installing #2811

Closed
mifi opened this issue Nov 28, 2016 · 1 comment
Closed

included devDependencies causes warning when installing #2811

mifi opened this issue Nov 28, 2016 · 1 comment
Labels
Milestone

Comments

@mifi
Copy link

mifi commented Nov 28, 2016

This is a Bug Report

Description

npm install -g serverless

└─┬ serverless@1.2.1 
...........
  ├── escope@3.6.0 
  ├── UNMET PEER DEPENDENCY eslint@^3.3.1
  ├── eslint-config-airbnb-base@5.0.3  extraneous
  ├── eslint-import-resolver-node@0.2.3 
  ├── UNMET PEER DEPENDENCY eslint-plugin-import@^1.13.0
  ├── espree@3.3.2 
..........

npm WARN eslint-config-airbnb-base@5.0.3 requires a peer of eslint@^3.3.1 but none was installed.
npm WARN eslint-config-airbnb-base@5.0.3 requires a peer of eslint-plugin-import@^1.13.0 but none was installed.

eslint-config-airbnb-base shouldn't be included in the first place? (in the publish)

It seems eslint-config-airbnb-base is referenced in npm-shrinkwrap.json. Maybe it needs to be re-generated from scratch?
rm npm-shrinkwrap.json && rm -rf node_modules && npm install && npm shrinkwrap

Similar or dependent issues:

Additional Data

  • 1.2.1
  • OSX Sierra
@mifi mifi changed the title devDependencies included included devDependencies causes warning when installing Nov 28, 2016
@pmuens pmuens added the bug label Nov 28, 2016
@dougmoscrop
Copy link
Contributor

I don't even think they should check in their shrinkwrap; they should produce it during CI or whatever steps release. so they can npm prune --production before npm shrinkwrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants