Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics command returning metrics for service #2846

Closed
mthenw opened this issue Dec 2, 2016 · 6 comments
Closed

metrics command returning metrics for service #2846

mthenw opened this issue Dec 2, 2016 · 6 comments
Assignees
Milestone

Comments

@mthenw
Copy link
Contributor

mthenw commented Dec 2, 2016

This is a Feature Proposal

Description

serverless metrics (without -f) should return aggregated metrics for whole service (all functions in service).

$ serverless metrics
December 1, 2016 10:34 AM - December 2, 2016 10:34 AM

Invocations: 19
Throttles: 12
Errors: 1
Duration (avg.): 92ms
@mthenw mthenw added this to the 1.4 milestone Dec 2, 2016
@pmuens pmuens self-assigned this Dec 5, 2016
@pmuens
Copy link
Contributor

pmuens commented Dec 5, 2016

This looks like a good improvement! Maybe we should add an All functions combined or something like that where usually the function name appears if you run this command with a --function option.

@nikgraf
Copy link
Contributor

nikgraf commented Dec 6, 2016

I like it. Since we gathering all the data for all the functions I would propose we show data for functions separately. In addition we can add 99th percentile if it's already exposed to the API:

December 5, 2016 7:47 PM - December 6, 2016 7:47 PM

All functions
Invocations: 19
Throttles: 12
Errors: 1
Duration (avg.): 92ms
Duration (99th.): 92ms

serverless-simple-http-endpoint-dev-currentTime
Invocations: 0 
Throttles: 0 
Errors: 0 
Duration (avg.): 0ms
Duration (99th.): 92ms

serverless-simple-http-endpoint-dev-createTodo
Invocations: 0 
Throttles: 0 
Errors: 0 
Duration (avg.): 0ms
Duration (99th.): 92ms

@mthenw
Copy link
Contributor Author

mthenw commented Dec 7, 2016

hmm, IMHO when -f is not specified we should show only

December 5, 2016 7:47 PM - December 6, 2016 7:47 PM

All functions
Invocations: 19
Throttles: 12
Errors: 1
Duration (avg.): 92ms
Duration (99th.): 92ms

@pmuens
Copy link
Contributor

pmuens commented Dec 7, 2016

I like and see the value of showing all functions but IMHO it can get pretty confusing if you have many functions. So showing only the stuff for "All functions" might be easier to grasp.

@pmuens
Copy link
Contributor

pmuens commented Dec 8, 2016

So should we start with @mthenw proposal?

Would start the implementation if everyone is fine with that and submit a PR where we can discuss the implementation details.

@pmuens
Copy link
Contributor

pmuens commented Dec 12, 2016

Just pushed a PR (#2922) which implements @mthenw proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants