Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to enable AWS api logging without full request/response #6209

Open
emsearcy opened this issue Jun 3, 2019 · 1 comment
Open

Option to enable AWS api logging without full request/response #6209

emsearcy opened this issue Jun 3, 2019 · 1 comment

Comments

@emsearcy
Copy link

emsearcy commented Jun 3, 2019

Feature proposal for more granular AWS API Gateway logging

Description

Actual behavior:

  • Enabling logging at the API GW level via provider->logs->restApi=true is useful, but it also adds "log full requests/responses data" (/*/*/logging/dataTrace), which may not be desired due to compliance requirements or just plain cost concerns

dataTrace = { op: 'replace', path: '/*/*/logging/dataTrace', value: 'true' };

Desired behavior:

  • Cloudwatch basic logs, cloudwatch full (dataTrace) logs, and access logging can be individually enabled/disabled.

Nice to have: have option of overriding the access log format and CloudWatch Group (in a shared API GW situation, you don't want the service name being encoded into the CloudWatch Group).

@jurajseffer
Copy link

This would be nice but I wonder why SLS is even touching those settings when they're not specified. SLS allows for externally created API gateway to be used but whenever a deployment happens it resets the logging settings. It should not touch them unless logs block is specified in SLS config.

let logLevel = { op: 'replace', path: '/*/*/logging/loglevel', value: 'OFF' };

It doesn't touch other settings such as throttling so it should be consistent and leave logging alone too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants