Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed versions in package.json dependencies. #6666

Closed
jakobnordztrom opened this issue Sep 11, 2019 · 1 comment
Closed

Use fixed versions in package.json dependencies. #6666

jakobnordztrom opened this issue Sep 11, 2019 · 1 comment
Labels

Comments

@jakobnordztrom
Copy link

This is a Feature Proposal

Description

  • Most dependencies in package.json allow for minor version updates, ie are prefixed with ^. This allows bugs in new releases of dependencies to break existing serverless releases (e.g what happened in issues error during sls deploy #6659). To ensure a stable and immutable release do not allow for version updates in package.json. Use fixed versions instead.

Similar or dependent issues:

@medikoo
Copy link
Contributor

medikoo commented Sep 11, 2019

@jakobnordztrom Great thanks for proposal, still I don't think it's a path we we should follow.

It's a project installed usually as one of the dependencies and applying this practice may imply a numerous nasty side effects for projects that rely on it. Also we need to be able to update framework dependencies without a need of producing framework releases for every such case.

A fine grain control of a dependencies versioning should rather be done on a project level instead, and over there you can easily control that with package-lock.json or yarn.lock.


#6659 was fixed on aws-sdk side, also with today's release we've ensured that buggy version will not install with a new version of the framework.

@medikoo medikoo closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants