-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BisectBatchOnFunctionError option for Dynamo and Kinesis event sourcing #7105
Add BisectBatchOnFunctionError option for Dynamo and Kinesis event sourcing #7105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7105 +/- ##
==========================================
- Coverage 88.66% 88.39% -0.28%
==========================================
Files 231 234 +3
Lines 8479 8545 +66
==========================================
+ Hits 7518 7553 +35
- Misses 961 992 +31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jchaasis great thanks, that looks great! I've just added one minor suggestion
@medikoo - bump :). Hoping it can make it into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jchaasis looks great!
I see this has been dropped from |
@walenzack it'll be published with v1.61.0 most likely on Monday |
What did you implement
Add the ability to configure the BisectBatchOnFunctionError feature for failure handling on Kinesis and DynamoDB streams.
Closes #7041
How can we verify it
Sample serverless.yml:
Todos
Useful Scripts
npm run test:ci
--> Run all validation checks on proposed changesnpm run lint:updated
--> Lint all the updated filesnpm run lint:fix
--> Automatically fix lint problems (if possible)npm run prettier-check:updated
--> Check if updated files adhere to Prettier confignpm run prettify:updated
--> Prettify all the updated filesIs this ready for review?: YES
Is it a breaking change?: NO