Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BisectBatchOnFunctionError option for Dynamo and Kinesis event sourcing #7105

Conversation

jchaasis
Copy link
Contributor

@jchaasis jchaasis commented Dec 17, 2019

What did you implement

Add the ability to configure the BisectBatchOnFunctionError feature for failure handling on Kinesis and DynamoDB streams.

Closes #7041

How can we verify it

Sample serverless.yml:

functions:
  preprocess:
    handler: handler.preprocess
    events:
      - stream:
          arn: arn:aws:kinesis:region:XXXXXX:stream/foo
          bisectBatchOnFunctionError: true

Todos

Useful Scripts
  • npm run test:ci --> Run all validation checks on proposed changes
  • npm run lint:updated --> Lint all the updated files
  • npm run lint:fix --> Automatically fix lint problems (if possible)
  • npm run prettier-check:updated --> Check if updated files adhere to Prettier config
  • npm run prettify:updated --> Prettify all the updated files
  • Write and run all tests
  • Write documentation
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #7105 into master will decrease coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7105      +/-   ##
==========================================
- Coverage   88.66%   88.39%   -0.28%     
==========================================
  Files         231      234       +3     
  Lines        8479     8545      +66     
==========================================
+ Hits         7518     7553      +35     
- Misses        961      992      +31
Impacted Files Coverage Δ
...plugins/aws/package/compile/events/stream/index.js 98.82% <100%> (+0.02%) ⬆️
lib/Serverless.js 100% <0%> (ø) ⬆️
lib/classes/CLI.js 95.72% <0%> (ø) ⬆️
lib/classes/Utils.js 94.73% <0%> (ø) ⬆️
lib/classes/Error.js 97.18% <0%> (ø) ⬆️
lib/utils/npm-command-deferred.js 77.77% <0%> (ø)
lib/utils/isStandaloneExecutable.js 100% <0%> (ø)
lib/plugins/executable/index.js 34.09% <0%> (ø)
lib/plugins/plugin/install/install.js 98.61% <0%> (+0.03%) ⬆️
lib/plugins/aws/customResources/generateZip.js 89.28% <0%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29d169...5e570ea. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jchaasis great thanks, that looks great! I've just added one minor suggestion

lib/plugins/aws/package/compile/events/stream/index.js Outdated Show resolved Hide resolved
@medikoo medikoo added this to the 1.61.0 milestone Dec 18, 2019
@neverendingqs
Copy link
Contributor

@medikoo - bump :). Hoping it can make it into 16.1.0 if possible.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jchaasis looks great!

@medikoo medikoo merged commit 560ceee into serverless:master Jan 7, 2020
@medikoo medikoo removed this from the 1.61.0 milestone Jan 7, 2020
@walenzack
Copy link

I see this has been dropped from 1.61.0. Any tips on when will it be available?

@medikoo
Copy link
Contributor

medikoo commented Jan 10, 2020

@walenzack it'll be published with v1.61.0 most likely on Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expose Bisect on Function Error prop for Kinesis Streams
7 participants