Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config schema: Define AWS "provider" properties #8022

Closed
7 tasks done
medikoo opened this issue Jul 31, 2020 · 2 comments
Closed
7 tasks done

Config schema: Define AWS "provider" properties #8022

medikoo opened this issue Jul 31, 2020 · 2 comments

Comments

@medikoo
Copy link
Contributor

medikoo commented Jul 31, 2020

Use case description

It'll be nice to have provider section fully covered by schema validation (for AWS provider case)

Proposed solution

Follow up to #6562, with which only schema placeholder for provider was configured.

Configuration should probably be done directly in: lib/plugins/aws/provider/awsProvider.js, what it covers was split into following issues:

After all above issues are addressed, we may remove schema relaxation configured in lib/classes/ConfigSchemaHandler/index.js

@pgrzesik
Copy link
Contributor

Hey @medikoo 👋 I think we have all of these crossed out - are we safe to close this issue now?

@medikoo
Copy link
Contributor Author

medikoo commented Feb 12, 2021

@pgrzesik indeed, missed that! Great you've noticed. Closing

@medikoo medikoo closed this as completed Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants